fix: confirm before discarding an incomplete recording - #2459

Fixes #2365

In the Tauri app (apps/desktop), the recovery toast's Discard button deleted the whole recording folder as soon as it was clicked. In #2365, that's how a 38-minute recording was lost after recovery kept failing. That recovery failure is #2386, fixed in #2458.

Discard now asks first, using the prompt the library's delete button already uses: "Are you sure you want to delete this recording?" The GPUI app already shows this same confirmation before its Discard (MainWindow::process_incomplete_recording), so the shipping app needs no change.

Testing

• Biome and tsc -p apps/desktop --noEmit pass.
• dialog:default is granted to every window (capabilities/default.json), so ask() works in the main window where the toast renders.
• Hand-tested in bun run dev:desktop on macOS 27.0.1:
  • With an incomplete recording listed, Discard shows "Are you sure you want to delete this recording?"
  • No keeps the recording.
  • Yes deletes it, and logs a single Discarded incomplete recording line, at the moment of the Yes.
  • To get an incomplete recording, I force-killed the app during a Studio recording and set the recording's status to NeedsRemux. A force-killed InProgress Studio recording is marked Failed: "Recording crashed" at the next launch (resume_uploads), and the recovery toast skips Failed recordings, so it never offers Discard for one. That is existing behaviour, unrelated to this change.

Confidence Score: 5/5

Summary

RecoveryToast.tsx now asks before discarding an incomplete recording.

• The recovery toast asks before discarding an incomplete recording.

No actionable issues found. Review was based on source inspection; no runtime or visual checks were performed.

_{Reviews (1) · Last reviewed commit: "fix(desktop): confirm before discarding ..." · Reviewed by Greptile}